search

GispoCoding / eis_toolkit

Python library for mineral prospectivity mapping
https://eis-he.eu/
European Union Public License 1.2
26 stars 8 forks source link

257 add smoothing functions #289

Closed msmiyels closed 10 months ago

msmiyels commented 10 months ago

Modularized smoothing functions with example notebook.

There is one flake8 error, that wants[x : x, y : y] with no whitespace between the letters ([x:x, y:y]). However, once corrected, black re-formats it to the version with whitespaces. May give an error in the GitHub actions.

How we want to handle this?

Cheers, Micha

nmaarnio commented 10 months ago

I will review this today or tomorrow! When it comes to the linting issue, add # noqa: E203 at the end of the problematic line. That should do the trick

msmiyels commented 10 months ago

Ahh, good to know 👀 It did 🐱‍🏍

Thank you 😎

msmiyels commented 10 months ago

Ahoi Niko,

thank you for the good review ⚡

Oh man, you're totally right. Missed the metadata point completely 🤦‍♂️ I'll stick to the structure for the existing raster_processing tools and add the out_meta to the output.

Will address this and any other point ASAP 🚀

Best, Micha

msmiyels commented 10 months ago

Ahoi Niko 🏴‍☠️

think I got everything on the requested changes list covered so far 🤗

The docs stuff was pretty new to me, when did we add that? 👀 However, the build marked some minor docstring inconsistencies in the derivatives module, which are contained in the PR as well.

The notebook has been changed due to returning tuple instead of np.ndarray, too.

Let me know if there are other things to be changed 🐱‍👤

Cheers, Micha

Edit: We do not use the findpeaks package for the implemented filters, so there's no need to keep it in (or change) the eis_toolkit requirements 🧩

nmaarnio commented 10 months ago

Looks great now! ✨ It's basically ready to be merged, but I noticed one cell in the notebook didn't unpack the out_image, out_metatuple and therefore threw an error; if you quickly fix that, I'll merge then!

We have had the doc files since the beginning, but I have forgotten them from time to time myself and they haven't been discussed very frequently. However, it was only a couple months ago we started automatically building a PDF out of the docs and also publishing them here: https://gispocoding.github.io/eis_toolkit/

Regarding findpeaks: Good, makes things a bit simpler :D

msmiyels commented 10 months ago

Thank you ✨ Notebook is ready, then let's get it merged 😎

Good to know this for the doc's 🦄 Pretty handy ⚙