search

GispoCoding / pytest-qgis

A pytest plugin for testing QGIS python plugins
GNU General Public License v2.0
29 stars 8 forks source link

Do not use CRS operations before initializing QgsApplication #60

Closed Joonalai closed 3 months ago

Joonalai commented 4 months ago

Fixes #56 by not using any QgsCoordinateReferenceSystem before initialiszing QgsApplication.

Joonalai commented 4 months ago

@LKajan could you review this and maybe make another release afterwards?

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 57.25%. Comparing base (d5227a4) to head (369b7dc).

Files Patch % Lines
src/pytest_qgis/utils.py 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #60 +/- ## ========================================== - Coverage 57.66% 57.25% -0.41% ========================================== Files 7 7 Lines 496 496 ========================================== - Hits 286 284 -2 - Misses 210 212 +2 ``` | [Flag](https://app.codecov.io/gh/GispoCoding/pytest-qgis/pull/60/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GispoCoding) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/GispoCoding/pytest-qgis/pull/60/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GispoCoding) | `57.25% <0.00%> (-0.41%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GispoCoding#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LKajan commented 4 months ago

Thanks for this PR! I'm a bit busy right now, but I'll check this out in the next couple of days. I'll make a release then.