GitHawkApp / GitHawk

The (second) best iOS app for GitHub.
http://githawk.com
MIT License
2.88k stars 382 forks source link

Projects #318

Open Sherlouk opened 6 years ago

Sherlouk commented 6 years ago

Bit further a field but would be nice to get at least a read-only version of projects working

Alamofire have one here (Debugging purposes)

So going from a repo view we will want to immediately get a list of project and let the user pick one

The main interface will likely be a collection view for horizontal scrolling and then a list of either vertical collection views ~or table views~ (Unsupported by IGListKit).

"Cards" are all linked to issues so we may be able to re-use some models/cells there. Tapping on cards should obviously open the issue.

Long-term we should add the ability for members to drag and drop cards between the columns (some lovely new APIs to help with that!)

rnystrom commented 6 years ago

Related: we should start using projects for GitHawk

Sent with GitHawk

Sherlouk commented 6 years ago

I may look into this actually, looks like a bit of fun 🤔

Sherlouk commented 6 years ago

Storing GraphQL template until I get to this:

query {
  repository(owner: "Alamofire", name: "Alamofire") {
    projects(first: 10) {
      nodes {
        number
        name
        body
      }
    }

    project(number: 1) {
      columns(first: 10) {
        nodes {
          name
          cards(first: 1) {
            nodes {
              content {
                ... on Issue {
                  title
                }
                ... on PullRequest {
                  title
                }
              }
              note
              creator {
                login
                url
              }
            }
            totalCount
          }
        }
      }
    }
  }
}

A "card" can be either an Issue, Pull Request or Note (String).

rnystrom commented 6 years ago

A "card" can be either an Issue, Pull Request or Note (String).

Weird! Good to know tho.

rnystrom commented 6 years ago

@Sherlouk I just enabled projects board on this repo. I'll get some stuff scaffolded.

Sherlouk commented 6 years ago

@rnystrom Maybe keep this repo's projects for actual project stuffs, and use your test repo for it? (May need to give me access for when I get to edit stuffs 😅)

Just so we can see the different empty states

Sherlouk commented 6 years ago

@rnystrom Whereabouts do you think is a good time to put projects? Really it should be with Overview/Issues/PRs but it can't all fit on small screens 😞

Temporarily got it in the ... overflow menu

image

Basic list all wired up, need to add UI to indicate closed projects with a segmented control to flip between the two and paging -- Supports both with/without description

Sherlouk commented 6 years ago

image

Another shot, tapping through all works, basic column structure.

Technically they all support markdown in them - not sure how easy that'll be to add to these views so may need to revise

Progress though!

rnystrom commented 6 years ago

Probably want to move repo view to a swipable page control so we can have multiple tabs.

Sent with GitHawk

Sherlouk commented 6 years ago

@rnystrom Mocked up this:

image

The segmented control would not be visible on Overview, on the other three tabs it would act as a toggle between Open/Closed.

Would be scrollable to add new tabs in the future

Opinion?

BasThomas commented 6 years ago

Another shot, tapping through all works, basic column structure.

I can smell the drag and dropping action already. Love it!

Sherlouk commented 6 years ago

@BasThomas Going to be lush, but not sure how I'm going to do iOS 9/10 support for it 😞

I'm going to suggest we get out a read-only version first anyway!

BasThomas commented 6 years ago

Oh definitely, wasn't suggesting it should go in now. But would be awesome once it does :)

DevAndArtist commented 5 years ago

@Sherlouk why was your PR closed? This looked so promising.

Sherlouk commented 5 years ago

Honestly I can't remember, I believe I got caught up on the markdown handling at the time (this was before we had a super nice markdown handler!) so was finding it fairly complex to get that working.

I don't think it was particularly difficult though in terms of the UI etc, with the newer architecture it shouldn't be too bad if somebody were to pick this up. I'm so far behind understanding all the changes though so need to work out all the new stuff before I crack on with something big.

Would be ace with newer drag and drop APIs etc!

billybooth commented 5 years ago

As a start, it would be nice to get a visual representation of an Issue’s Project (and column) along with the Labels, Milestone, and Assignees in the Issue view.

We’ve recently started leveraging project boards as a replacement for a set of labels, and I’ve been wishing I could see the assigned Project and column for reference when reviewing Issues in GitHawk.

TimPerry commented 5 years ago

Hey, just started using the app, looks great so far but I really need projects support. Is there any update on this? Happy to help out :)