Messaging improvements - Githubissues

GitLiveApp / firebase-kotlin-sdk

A Kotlin-first SDK for Firebase

https://gitliveapp.github.io/firebase-kotlin-sdk/

Apache License 2.0

1.11k stars 153 forks source link

Messaging improvements #536

Closed BasBuijsen closed 3 months ago

BasBuijsen commented 3 months ago

This pr adds some functionality for the messaging framework that is most important in iOS and Android projects. It is only (un)subscribing to topics and retrieving FCM token. Adding more functionality is going to be hard because of the differences between the sdks.

This pr also has 2 very small improvements from my previous PR's.

Add analytics to readme
Fix file names in tests for storage to ensure parallelization is not a problem

BasBuijsen commented 3 months ago

@nbransby can you review this pr?

BasBuijsen commented 3 months ago

@nbransby it seems that the android tests keep running infinitely while there were already errors. Could you stop it before it keeps running for hours :)

Reedyuk commented 3 months ago

@nbransby it seems that the android tests keep running infinitely while there were already errors. Could you stop it before it keeps running for hours :)

rebase now and see if it works

BasBuijsen commented 3 months ago

Yay tests work now 🎉

Reedyuk commented 3 months ago

Yay tests work now 🎉

rocky-rockyiv-apollo-creed-stallone-carlweathers-bromance-bros-beach-fun-training-guys-americans-positivity-boxing-brosbeforehos (1)