search

GitTools / GitLink

Making .NET open source accessible!
MIT License
554 stars 86 forks source link

Add Gitlab support #192

Closed Liryna closed 6 years ago

Liryna commented 6 years ago

Feature description

Hi,

I am looking to make the gitlab integration. We can access to raw files the same way as github but with a basic api token. https://gitlab.com/repo/raw/${git_commit}/...?private_token=YOUR_TOKEN See: https://gitlab.com/gitlab-org/gitlab-ce/issues/19077

I wonder if we should 'just' add a param after -u to provide extram param on the URL ? or a param to say we are using gitlab ? Can someone guide me how this could be integrated in Gitlink ?

(I would contribute it to the project ofc)

GeertvanHorrik commented 6 years ago

Are the pdb files also hosted privately? Note that adding a private token can be a bad idea and cause your source files to be exposed. This is obviously always the case when you need a token to get source code behind a login wall, but just want to make sure you understand the implications.

Liryna commented 6 years ago

Hi @GeertvanHorrik ,

Yes, the pdb are also hosted privately in a network shared folder.

Liryna commented 6 years ago

Oh, my bad, have not seen the CustomUrlProvider. This will do the work 👍