[ISSUE]: GitReleaseManager GithubAction not logging to job

Stepami commented 1 month ago

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched issues to ensure it has not already been reported

GitReleaseManager package

GitHub Actions

What are you seeing?

https://github.com/Stepami/hydrascript/actions/runs/10360139446/job/28678471915

In GitHub Actions logs i see no logs of tool.

But if i run it locally logs appear:

What is expected?

logging to GitHub Actions Console

Steps to Reproduce

name: Release Workflow

on:
  push:
    branches:
      - 'release'

jobs:
  create-release:
    name: Create release
    runs-on: ubuntu-latest
    outputs: 
      determined_version: ${{ steps.version_step.outputs.majorMinorPatch }}
    steps:
      - name: Checkout
        uses: actions/checkout@v4
        with:
          fetch-depth: 0
      - name: Setup GitVersion
        uses: gittools/actions/gitversion/setup@v3.0.0
        with:
          versionSpec: '5.12.0'
      - name: Determine Version
        id: version_step
        uses: gittools/actions/gitversion/execute@v3.0.0
        with:
          useConfigFile: true
      - name: Setup GitReleaseManager
        uses: gittools/actions/gitreleasemanager/setup@v3.0.0
        with:
          versionSpec: '0.18.x'
      - name: Create release with GitReleaseManager
        uses: gittools/actions/gitreleasemanager/create@v3.0.0
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          owner: 'Stepami'
          repository: 'hydrascript'
          milestone: 'v${{ steps.version_step.outputs.majorMinorPatch }}'
          name: 'v${{ steps.version_step.outputs.majorMinorPatch }}'

Output log or link to your CI build (if appropriate).

No response

arturcic commented 1 month ago

@gep13

arturcic commented 1 month ago

Prerequisites

[x] I have written a descriptive issue title
[x] I have searched issues to ensure it has not already been reported

GitReleaseManager package

GitHub Actions

What are you seeing?

https://github.com/Stepami/hydrascript/actions/runs/10360139446/job/28678471915

In GitHub Actions logs i see no logs of tool.

But if i run it locally logs appear:

What is expected?

logging to GitHub Actions Console

Steps to Reproduce

name: Release Workflow

on:
  push:
    branches:
      - 'release'

jobs:
  create-release:
    name: Create release
    runs-on: ubuntu-latest
    outputs: 
      determined_version: ${{ steps.version_step.outputs.majorMinorPatch }}
    steps:
      - name: Checkout
        uses: actions/checkout@v4
        with:
          fetch-depth: 0
      - name: Setup GitVersion
        uses: gittools/actions/gitversion/setup@v3.0.0
        with:
          versionSpec: '5.12.0'
      - name: Determine Version
        id: version_step
        uses: gittools/actions/gitversion/execute@v3.0.0
        with:
          useConfigFile: true
      - name: Setup GitReleaseManager
        uses: gittools/actions/gitreleasemanager/setup@v3.0.0
        with:
          versionSpec: '0.18.x'
      - name: Create release with GitReleaseManager
        uses: gittools/actions/gitreleasemanager/create@v3.0.0
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          owner: 'Stepami'
          repository: 'hydrascript'
          milestone: 'v${{ steps.version_step.outputs.majorMinorPatch }}'
          name: 'v${{ steps.version_step.outputs.majorMinorPatch }}'

Output log or link to your CI build (if appropriate).

No response

@Stepami I hope you have revoked/removed that token you forgot to hide in the screenshot.

As for the output, at this point the GitVersion and GitReleaseManager actions/tasks are some opinionated wrappers around the command line tools, and the implementation is not logging the successful output, but only the error message if any.

I think I can agree it can be improved with a common setting to enable the tool output for all actions we support.

@Stepami are you willing to create a PR for this, and I can give some input on this.

Stepami commented 1 month ago

@arturcic The token is no longer available, so don't you worry)

the thing is implementation is not logging the error message as well

that is the reason i created the issue in a first place

i tried to make an automated release, but it didn't happen. after local launch it turned out i've used labels in wrong way, which became clear from error messages i got locally on my machine

so, you should check error output firstly, i think

on the contrary gitversion action works great

siruschavoshi commented 1 month ago

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched issues to ensure it has not already been reported

GitReleaseManager package

GitHub Actions

What are you seeing?

https://github.com/Stepami/hydrascript/actions/runs/10360139446/job/28678471915

In GitHub Actions logs i see no logs of tool.

But if i run it locally logs appear:

What is expected?

logging to GitHub Actions Console

Steps to Reproduce

name: Release Workflow

on:
  push:
    branches:
      - 'release'

jobs:
  create-release:
    name: Create release
    runs-on: ubuntu-latest
    outputs: 
      determined_version: ${{ steps.version_step.outputs.majorMinorPatch }}
    steps:
      - name: Checkout
        uses: actions/checkout@v4
        with:
          fetch-depth: 0
      - name: Setup GitVersion
        uses: gittools/actions/gitversion/setup@v3.0.0
        with:
          versionSpec: '5.12.0'
      - name: Determine Version
        id: version_step
        uses: gittools/actions/gitversion/execute@v3.0.0
        with:
          useConfigFile: true
      - name: Setup GitReleaseManager
        uses: gittools/actions/gitreleasemanager/setup@v3.0.0
        with:
          versionSpec: '0.18.x'
      - name: Create release with GitReleaseManager
        uses: gittools/actions/gitreleasemanager/create@v3.0.0
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          owner: 'Stepami'
          repository: 'hydrascript'
          milestone: 'v${{ steps.version_step.outputs.majorMinorPatch }}'
          name: 'v${{ steps.version_step.outputs.majorMinorPatch }}'

Output log or link to your CI build (if appropriate).

No response

GitTools / actions