Giveth / GIVfi

GNU General Public License v3.0
1 stars 2 forks source link

Add Withdrawal Event #18

Open divine-comedian opened 1 year ago

divine-comedian commented 1 year ago

We should have a withdrawal event emitted when a user makes a withdrawal of funds from GIVsavings.

Current we only have several Transfer events, one of which is the withdrawal but we should have an explicit Withdraw event to make the subgraph work easier.

Here is a sample of the current withdraw tx logs: https://goerli-optimism.etherscan.io/tx/0x6427e55a5c957cb07db28b5bb91f2ec4f908d887659c01e3744ec7283a07bc5b#eventlog

0xKurt commented 1 year ago

I updated the proxy with the new implementation: https://goerli-optimism.etherscan.io/address/0x765e3bb0a61451D8567b932af7043cAFcDBCf7ee#code

i added the following events:

    event Deposited(
        address indexed user,
        address indexed recipient,
        uint256 amount,
        uint256 shares
    );
    event Withdrawn(
        address indexed user,
        address indexed recipient,
        uint256 shares,
        uint256 amount
    );
maryjaf commented 1 year ago

How can I test this issue?

divine-comedian commented 1 year ago

How can I test this issue?

Sorry this is an old issue for GIVfi which has stopped development - we can icebox this one