Donation with the same QR won't appear in project donation list

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo

https://staging.giveth.io

GNU General Public License v3.0

64 stars 33 forks source link

Donation with the same QR won't appear in project donation list #4667

Open maryjaf opened 2 months ago

maryjaf commented 2 months ago

The users be able to donate to a project twice with one QR code In this situation one of these donations is shown in project donations and user donations list

for example these two transaction was made by a QR code and the one of them is shown in project donation table

Transaction ad504d24e7b83b0e22f152b4643361756dcbbee1c4aac0371137b806bf6e6c46

Transaction d02a1bf00da3ffcc344d4700ff2dfadfe3d28bd981a8765565a8fcf27babd305 (it is shown in list of project donation)

cc: @MoeNick

maryjaf commented 2 months ago

https://github.com/Giveth/giveth-dapps-v2/issues/4591#issuecomment-2324064085

Meriem-BM commented 2 months ago

Implementation: After a transaction is detected by the cron job, an additional check is triggered 2 seconds later. This second check searches for any similar transactions that match specific criteria: the same source address, destination address, amount, and (if provided) memo, with a timestamp within 1 minute of the initial transaction. If such a matching transaction is found, a new donation is created.

cc: @maryjaf

maryjaf commented 2 months ago

I think this implementation makes some problem consider this scenario:

I tap on donate with a sign user (maryam )on chrome
the amount is 0.01
I complete donation flow and it is success
At the same time I make another donation with not signed user on firefox with same amount
I complete this donation flow also
in this case I see two record in donation table for maryam user and my donation in firefox is still shown pending

@Meriem-BM

maryjaf commented 2 months ago