search

Giveth / impact-graph

MIT License
49 stars 18 forks source link

Remove RegisterResolver and ConfirmUserResolver resolvers and their dependencies #1316

Closed aminlatifi closed 1 month ago

aminlatifi commented 7 months ago

As the impact-graph project was originally designed for another purpose and then refactored for Giveth by the initial dev team, some code leftovers are not aligned with the current application. One important functionality (which I am not sure is working yet) is allowing users to register with a password, as is traditional in web2. So, if we all agree that this feature is not used, we must remove it asap.

aminlatifi commented 7 months ago

@jainkrati @mohammadranjbarz @CarlosQ96 @MoeNick

mohammadranjbarz commented 7 months ago

@jainkrati @mohammadranjbarz @CarlosQ96 @MoeNick

I totally agree, we have lots of unused codes that it's better to be deleted

CarlosQ96 commented 7 months ago

Yeah I agree, if those endpoints are not used by frontend, we can remove them. The impact graph grew a lot.

jainkrati commented 7 months ago

@MoeNick pls confirm if we should remove the feature "allow user to register with password"

MoeNick commented 7 months ago

Yeah its deprecated. We can go ahead to remove. Im not sure its P1, I'd put p2, unless if it has a tech priority.

aminlatifi commented 7 months ago

Removing those also allows us to delete some dependencies that are so dated and have vulnerabilities. One is nodemailer package

RamRamez commented 6 months ago

I wonder why "REGISTER_USERNAME_PASSWORD" is true in config file, because we are not using it in FE. image

RamRamez commented 6 months ago

The PR for this issue is ready. I'll merge it on staging after SuperFluid release.