Giveth vaultcontroller issues

Giveth / vaultcontroller

Vault Architecture

GNU General Public License v3.0

0 stars 3 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Configure Renovate

#51 renovate[bot] opened 1 year ago
0
primaryVault.authorizeSpender doesn't authorize vault controller contract

#50 ghost closed 7 years ago
1
Too much automation within the smart contract; move it up a level

#49 GriffGreen opened 7 years ago
0
Consider refactoring into ~4 contracts (or more)

#48 GriffGreen opened 7 years ago
0
unreachable condition in topUpVault

#47 adria0 opened 7 years ago
0
topUpVault() does not respect lowestAcceptableBalance

#46 adria0 closed 7 years ago
2
topUpVault() does not respect dailyAmountLimit/txnAmountLimit

#45 adria0 closed 7 years ago
2
initializeChildVault/setChildVaultLimits bad _dailyTxnLimit check

#44 adria0 closed 7 years ago
3
2 renaming suggestions

#43 GriffGreen opened 7 years ago
0
MAX_GENERATIONS limit

#42 adria0 closed 7 years ago
1
Unreachable condition in checkSpenderTransfer

#41 adria0 opened 7 years ago
5
cancelling a root vault causes owner == 0 [?]

#40 adria0 opened 7 years ago
1
Unreachable condition in checkMainTransfer

#39 adria0 opened 7 years ago
0
Cancelling the root vault causes founds to be lost

#38 adria0 opened 7 years ago
0
Current utc_hour_of_day calculation

#37 adria0 closed 7 years ago
1
Add recipient can be added/removed from a removed spender

#36 adria0 closed 7 years ago
2
Deleted/active recipients flag

#35 adria0 opened 7 years ago
7
Removing non-existent recipient does not fail

#34 adria0 closed 7 years ago
1
Re-authorizing an existent recipient does not fail if names are not equal

#33 adria0 closed 7 years ago
4
removeAuthorizedSpender does not update numberOfSpenders

#32 adria0 closed 7 years ago
1
removeAuthorizedSpender using msg.sender as spender

#31 adria0 closed 7 years ago
2
authorizeSpender of existent spender increments numberOfSpenders()

#30 adria0 closed 7 years ago
1
_openingTime/_closingTime checks

#29 adria0 closed 7 years ago
1
setVaultLimits cannot be set if there's no parentVaultController

#28 adria0 closed 7 years ago
1
24h time windows

#27 adria0 opened 7 years ago
6
initializeVault extra parameter checks

#26 adria0 closed 7 years ago
2
Bypassable limits

#25 adria0 opened 7 years ago
2
Problematic throw canceling uninitialized vaultcontroller

#24 adria0 closed 7 years ago
1
cancelVault() should return true if already cancelled

#23 adria0 closed 7 years ago
1
Resolves #6, comment into sendBackOverflow()

#22 adria0 closed 7 years ago
0
Parent Vault == 0x0 burns ether when overflow

#21 GriffGreen closed 7 years ago
3
It's not possible to remove ETH/Tokens from a canceled vault.

#20 jbaylina opened 7 years ago
6
Duplicated logic in checkMainTransfer and checkSpenderTransfer

#19 adria0 opened 7 years ago
1
VaultsLimitChanged event should log changes?

#18 adria0 closed 7 years ago
1
Rename primaryVault and topUpVault

#17 adria0 opened 7 years ago
5
Use modifier in checkMainTransfer

#16 adria0 closed 7 years ago
2
Set checkXXXX as constant

#15 adria0 opened 7 years ago
1
Add isInitialized()

#14 adria0 closed 7 years ago
1
Duplicated check in topUpVault()

#13 adria0 closed 7 years ago
1
Magic numbers

#12 adria0 closed 7 years ago
4
Out-of-gas attack

#11 adria0 closed 7 years ago
1
overflows in checkSpenderTransfer

#10 adria0 closed 7 years ago
1
overflow in checkMainTransfer

#9 adria0 closed 7 years ago
1
setVaultLimits checks

#8 adria0 closed 7 years ago
1
Vault cannot be cancelled if balance is zero

#7 adria0 closed 7 years ago
1
internal sendBackOverflow()

#6 adria0 closed 7 years ago
2
name changes and a request to review :-)

#5 GriffGreen closed 7 years ago
1
made comments

#4 GriffGreen closed 7 years ago
0
A few more comments

#3 GriffGreen closed 7 years ago
1
2 comments and 43 name changes :-)

#2 GriffGreen closed 7 years ago
1