Gizra / drupal-starter

Drupal 10 Starter with best practices
76 stars 40 forks source link

Create button on the sidebar disappears when clicking it #725

Open balagan73 opened 1 month ago

balagan73 commented 1 month ago

I guess the aria-controls="admin-toolbar" attribute was removed from the button, and now when clicking the Create button it will be hidden.

Before clicking After clicking
image image

Need to adjust web/themes/custom/server_theme/src/js/toggler.js

sonvir249 commented 1 week ago

@balagan73 It appears to affect all buttons that have hover functionality and it's happening on all node view pages.

amitaibu commented 1 week ago

@sonvir249 care to try and fix it? 😄

sonvir249 commented 1 week ago

@amitaibu Yes, raised a PR to fix the issue, Please review it and let me know if any changes needed. Thanks!

amitaibu commented 1 week ago

@sonvir249 Thanks. Out of curiosity, where did you learn about Drupal-starter? Are you using it for your project(s)?

sonvir249 commented 1 week ago

@amitaibu You are welcome. I am not using Drupal-starter on any of the project. I was exploring Robo for task automation and looking into how tools like BLT, Drush, and Pantheon Terminus integrate Robo for PHP tasks. During my poc/research, I discovered Drupal-starter.