GlacioHack / xdem

Analysis of digital elevation models (DEMs)
https://xdem.readthedocs.io/
Apache License 2.0
148 stars 41 forks source link

Default `fit_sum_model_variogram` can overfit short ranges #613

Open rhugonnet opened 1 month ago

rhugonnet commented 1 month ago

See for example fit below, courtesy of Julian Llanto: Screenshot from 2024-10-23 15-33-02

We should better adapt default arguments, maybe prevent a range shorter than X times the resolution? And prevent a fit within X times that of another range? (by some iterative process re-doing the fit several times and adjusting the bounds?) Not sure what the most robust method would be here :thinking:.

erikmannerfelt commented 2 weeks ago

For the moment, would it be possible to define threshold for when it becomes a problem and then trigger a warning if someone tries anyway?

rhugonnet commented 2 weeks ago

It doesn't seem to happen so often from what I hear... so maybe we can leave as is for now, until we add an enhancement.