search

GladistonXD / perlego-download

Google chrome extension
39 stars 10 forks source link

Comma at the end of every page #5

Closed H9RuH2d closed 10 months ago

H9RuH2d commented 10 months ago

Hello! First of all, thank you very much for this extension -- it works great!

I just wanted to report that I seem to be getting a comma at the end of every page of the PDF (it shows up in the HTML too)

Here is an image of a blank page. The comma is in the bottom left. It's in the same spot on every page.

image
GladistonXD commented 10 months ago

Hello! First of all, thank you very much for this extension -- it works great!

I just wanted to report that I seem to be getting a comma at the end of every page of the PDF (it shows up in the HTML too)

Here is an image of a blank page. The comma is in the bottom left. It's in the same spot on every page.

image

Does it appear to you in all books or just in a specific one?

H9RuH2d commented 10 months ago

I just tried another PDF and got the same result. Doesn't happen with EPUBs. It seems like there's a comma being inserted between every <br> and the next <div>. For the time being I just used find/replace in VS Code to get rid of all of them, but pretty sure this can be taken care of in the extension itself?

GladistonXD commented 10 months ago

I just tried another PDF and got the same result. Doesn't happen with EPUBs. It seems like there's a comma being inserted between every <br> and the next <div>. For the time being I just used find/replace in VS Code to get rid of all of them, but pretty sure this can be taken care of in the extension itself?

I no longer have credentials for testing, but you can send an .html file and I will analyze it and make corrections in the code.

H9RuH2d commented 10 months ago

Will send it a bit later (mention me if I forget). Btw you can get a free trial, but it seems to not be available in some countries. I had to use a VPN.

GladistonXD commented 10 months ago

The output was adding arrays, I hadn't noticed that, I made a small correction https://github.com/GladistonXD/perlego-download/commit/af0c2b0b4cbd0b6a573cfae0a73f5e5bb287c3b7