search

Glain / FFTPatcher

FFTPatcher suite project continuation. Original commit is .483 RC 2
GNU General Public License v3.0
32 stars 9 forks source link

Shishi: Silently fails to patch sprite pngs created by other tools #24

Closed invadermonks closed 1 year ago

invadermonks commented 1 year ago

Shishi give the following result trying to patch 30 sprite pngs converted from BMP to PNG from TLW resources:

start /wait "Patch" ShishiSpriteEditor.exe -expand -patch "data\bugtest2\shishi_import" "output\fft_1685390769.bin" 2 sprites imported.

These patch fine as BMPs (giving 30 sprites imported) but converting them to PNGs causes only 2 to import, and gives no error message - so something is awry with png handling.

bugtest2_shishi_import.zip

Glain commented 1 year ago

@invadermonks There is now a more verbose logging of errors with commit c668a9a. The PNGs in the input file, save for 2, are in the wrong format. Some are 4bpp, and others seem to have no image data whatsoever and display as 1bpp. Sprites are expected to be imported from command line as 8bpp.

invadermonks commented 1 year ago

Good to know, I'll make sure my pngs are in the proper formats, thanks for the descriptive error messages now!