DG: Incorrect sequence diagram for find-by-item feature

[GlendaChong]

predicate should be initialised in Logic component instead of Model component. This confuses the reader on the implementation of the feature.

[nus-pe-script]

Team's Response

MenuContainsKeywordPredicate is under our model package in our code structure, thus it should be under Model instead of Logic.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: According to the forum issue #398, Prof Damith mentioned that

As the object added is created inside the Logic component (i.e., by the Parser), it should appear inside the Logic component (i.e., similar to the second diagram)

Even though MenuContainsKeyWordPredicate is under your model package, it is created inside the FindItemCommandParser class at line 40, which is inside the Logic component. Therefore, I believe that the sequence diagram is incorrect for the predicate, as MenuContainsKeyWordPredicate object should appear inside the Logic component.

The relevant code for creation of the predicate in the parser class is shown below:

---