search

GlimpseArchive / Glimpse.Client.Prototype

Glimpse v2 Client prototype
MIT License
9 stars 3 forks source link

Add "raw" body request/response sub-tabs to Request tab. #141

Closed philliphoff closed 8 years ago

philliphoff commented 8 years ago

Adds a "raw" sub-tab to the request/response tabs within the Request tab, displaying the un-formatted, un-highlighted body content of the request/response.

screen shot 2016-06-24 at 9 23 51 am

philliphoff commented 8 years ago

Associated with #135.

avanderhoorn commented 8 years ago

Looks great, just the quote usage nit.

avanderhoorn commented 8 years ago

I just realized, this quite the right functionality for the tab. This tab is supposed to show the "whole" raw req/res. Currently this just shows the raw body, but the whole raw req/res also includes the heads, body, etc.

nikmd23 commented 8 years ago

Yeah, at @avanderhoorn just mentioned, this should show the raw HTTP request or response.

avanderhoorn commented 8 years ago

Are you happy that this is a reconstruction vs an exact copy? An exact copy would require us to essentially have all the data duplicated.

nikmd23 commented 8 years ago

I'm happy with it being a reconstruction. Just watch things like the sort order for headers, and capitalization, we'll want to get those right.

avanderhoorn commented 8 years ago

Re sort order... I'm not 100% sure if we get in at the level where sort order is maintained. Additionally on the response we may not get all headers since some headers are added downstream of where we tap.

philliphoff commented 8 years ago

I'm happy with it being a reconstruction. Just watch things like the sort order for headers, and capitalization, we'll want to get those right.

We won't necessarily get the actual sort order for headers, as it's just a map with no guarantees about enumeration order. (We could theoretically capture set order within the application for responses, but that's not necessarily transmittal order.) The proxies also do not, currently capture the exact capitalization of set headers (as the spec says they are case-insensitive way).

avanderhoorn commented 8 years ago

Closing for the time being.