search

GlowstoneMC / Shine

Glowstone's plugin database
MIT License
3 stars 1 forks source link

Cleanup #1

Closed picknchew closed 7 years ago

picknchew commented 7 years ago

Refactoring Swig -> Handlebars ExpressJS 3 -> ExpressJS 4

aramperes commented 7 years ago

Great work :)

Although my nodejs branch was more of an experiment, I'm glad you expanded on it to make it much better.

@mastercoms @gdude2002 are we OK to make Shine in NodeJS? If so, we can merge this PR into master and start from there.

gdude2002 commented 7 years ago

I'll be honest with you, I don't like Node and I don't want this project to be written in Node.

If you're happy to work on it yourself, that's fine, but I won't be able to help you if you decide to stick with it. Up to you, imo.

gdude2002 commented 7 years ago

You're not everyone involved 😛

gdude2002 commented 7 years ago

Since this has already been merged, here's some JSLint for you. http://bamboo.gserv.me/browse/GSPP-SHINE/latest