purepvd
commented
11 months ago @purepvd Thanks for your contribution!
This all looks good, however I see that the 'catch' in DeploymentFilter now throws, and I'm not certain of the impact here.
Right. It seemed an odd choice to me to swallow errors here. If you're running a publish where you want to exclude parts of your schema (etc), and an error happens, why would you want it to continue updating your database?
There isn't anything in the catch block handling the error. Thoughts?
@purepvd Thanks for your contribution!
This all looks good, however I see that the 'catch' in DeploymentFilter now throws, and I'm not certain of the impact here.