search

Gobluebro / Elden-Ring-Checklist

A checklist for you to complete as you go through Elden Ring.
https://gobluebro.github.io/Elden-Ring-Checklist/
MIT License
72 stars 25 forks source link

Update Map Link functionality #27

Closed davvolun closed 9 months ago

davvolun commented 2 years ago

Partly discussed on PR #25

Idea is to update the map links to be styled nicely, fitting with the design, and with appropriate UI/UX.

Suggestion is to use the JSX.Element (types: description: string | JSX.Element) to allow inline links.

@Gobluebro I'm planning on doing this myself, but please insert any requirements/suggestions.

Gobluebro commented 2 years ago

Should be able to use https://reactjs.org/docs/dom-elements.html#dangerouslysetinnerhtml to add the jsx to the component. Despite the scary name it will be fine.

Gobluebro commented 9 months ago

Requested changes completed in 06caa17