Closed somespecialone closed 2 years ago
Out of interest what does pycharm think about Client? I would have thought it would make it steam.Client | csgo.Client and it doesn't care about unions handling every case.
Out of interest what does pycharm think about Client? I would have thought it would make it steam.Client | csgo.Client and it doesn't care about unions handling every case.
Maybe all variable messed this up, i am not sure. PyCharm shows right methods in autocomplete, but don't properly handle iheritance(multiple inheritance too, same problem to other parent classes if Client in there), signature of methods, which methods are overriden, super() call
Oh I remember that being an issue and just being confused. Thanks for this.
Hi! I really like your work, so thank you for that! I found, that little annoying moment - my Pycharm code inspection didn't work properly, so i decided to fix it. Also, while i closed the client, connect method always throws ConnectionReset exception. After some inspection i made sure that problem was there:
Unconditional while loop working and coroutine even after client is closed, expectedly, send message to GC trougth closed connection that throws error. I offer simple solution - check is_closed() in while. By the way, you already do this in connect method of steam.Client:
I will be grateful if you accept this PR :)