search

Godzil / Crunchy

Crunchy is capable of downloading anime episodes from the popular CrunchyRoll streaming service.
MIT License
95 stars 19 forks source link

Bring Episode Filtering Back Please! #74

Closed btm1 closed 6 years ago

btm1 commented 6 years ago

Is your feature request related to a problem? Please describe. It looks like you took out the ability to filter the episodes and this functionality was working perfectly for me. I was using mac Automator to automatically go and fetch new episodes every day using -e. If you've taken this out how do I make sure I'm only pulling new episodes?

Describe the solution you'd like I'd like to be able to specify a specific episode i'm looking for and be able to provide -/+ for less than or greater than.

Describe alternatives you've considered the ability for crunchy to accept a url of a specific episode. I could use the crunchyroll rss feed to get the url of the latest episode.

Godzil commented 6 years ago

I remove this (non) feature because it was buggy and non efficient.

Crunchy allow from a long time now to download a single episode with the @ syntax:

crunchy -u "foo" -p "bar" @http://www.cr.com/island/episode-2-i-dont-want-you-to-feel-bad-112233

where the URL is the URL of the episode you want.

Another point, if you are using the URL of a series, Crunchy don't download again the episodes it have already downloaded so if you've downloaded episodes 1-20 when episode 21 is out, calling Crunchy from the same folder it will not re-download episode 1 to 20.

Crunchy is really designed to be used from the same (output) folder or a lot of its mechanisms are not going to work properly

I see that the @ syntax is missing in the readme, I will correct that.

johnfigs commented 6 years ago

@Godzil the problem I see is for people that have switched computers and don't have their historical log file of episodes downloaded. For example, I downloaded all of one piece on computer A. After the hard drive went bad, I switched to computer B, I was using -e to start where I left off on computer A. If I run the crunchy command on computer B without the @ (because I need to download like 10 videos) it's going to want to download all the 100s of videos before it.

Godzil commented 6 years ago

-e X was never meant to be from X and onward. Using it this way was due to a bug and bad coding. It was mean to be just "episode X" I understand your point, the problem is that you were using it in a way it was never intended.

I will think about a remplacement that allow to do explicitely what you propose here, but the way this argument was working was not the one intended at all, and the @ form replace well the way it was intended.

The problem with Crunchy is that it is quite bloated, have a lot of poorly tested code, I'm trying to stream it down to a better manageable project, then will add back some potentially useful features. But the focus for now is to try to make is more reliable and future proof, removing what is not working properly which will probably be added back later in a new form.

Also, the parameter was reliying on what CR is setting, and I've seen a lot of inconsistency in their episode numbering. On some anime, a new season will reset the episode number to 1, on some other the number continue, etc...

Godzil commented 6 years ago

Release 1.3.5 add a new -e / --episode command line parameter. Please look at the readme to see how it work.