search

Godzil / Crunchy

Crunchy is capable of downloading anime episodes from the popular CrunchyRoll streaming service.
MIT License
95 stars 19 forks source link

Filtering out Pipe Symbol in file names #87

Closed TheDammedGamer closed 6 years ago

TheDammedGamer commented 6 years ago

Updated sanitiseFileName to include the pipe symbol as this character is not allowed on windows.

The error thast it currently throws is: {"errno":-4058,"code":"ENOENT","syscall":"open","path":"K:\MediaDwn\Is It Wrong to Try to Pick Up Girls in a Dungeon\Is It Wrong to Try to Pick Up Girls in a Dungeon - s01e01 - Bell Cranel | Adventurer - [CrunchyRoll].ass"

Checklist

[x] I've run npm run compile and it produce no error [x] I've run npm run test and it produce no error [x] I've not pushing more than one feature in that pull request [x] My branch is updated with the latest from main when I make that pull request [x] I've tested as much as I can my changes

codeclimate[bot] commented 6 years ago

Code Climate has analyzed commit da0fb170 and detected 0 issues on this pull request.

View more on Code Climate.

Godzil commented 6 years ago

:+1: I'm confused to have forgot that specific character, oops :sweat_smile:

Thanks a lot, will be in the next release (probably in a couple of day it there is changes to be done the ignoredub need to be updated for different languages.

Thanks a lot!