Goldenfreddy0703 / Otaku

Repository for Otaku Development
GNU General Public License v3.0
113 stars 22 forks source link

[Bug/Issue] Wrong name parsing when using UpNext folder with AniList compared to using the "Current" folder #211

Closed Nuklear92 closed 9 months ago

Nuklear92 commented 9 months ago

Okay, here are the details and I'll share screenshots down below showing the issue.

First of all, since Otaku doesn't support any sort of Trakt implementation within the addon's settings. I tend to use the official Trakt addon found in Kodi's Official Repository. The addon has a setting when you can universally Scrobbe any of your shows and movies from any addon when you set it up with your account, etc. Well, the issue lies when I play any episodes from within my UpNext folder. The Trakt addon can't detect the Episode being played due to the different way the name parsing shows. So, it doesn't kick in the Trakt scrobbe, unless I use the Current folder instead and look for the show, then episode manually. I could always do that. However, I like the less hassle way of just going into the UpNext folder instead and I can just one-click the in next episode from that exact show instead of doing too many clickings and scrollings specially since I have multiple shows within the Current folder.

So, in conclusion I was wondering if this is a thing that can be corrected for the Up Next folder. So, it starts showing the correct name parsing whenever there's a new Episode available to watch. That way the Trakt addon will be able to recognize the correct name parsing and successfully scrobbe the Episodes same as it does when you play them by going into the official title of the show, season and click on the Episode.

Here are some screenshots showing the difference in name parsing when using the Up Next folder and navigating manually into the title, season, and episode.

Current folder name parsing. image

image

Up-Next Folder name parsing. image

image

Goldenfreddy0703 commented 9 months ago

Hey so UpNext is quite weird when it comes to naming and episode which honestly, i don't understand at all, you may wanna ask @Gujal00 about this sense i know nothing about NextUp unfortunately. Now about your trakt scrobbling situation, you may not be able to scrobble every anime cause reason why is cause anime has a different database then what trakt offers, the closest thing to trakt i would recommend is simkl cause simkl is basically like trakt but with an anime supported database. It also supports trakt integration so you can import your trakt and all.

If you don't mind, see how Seren does there UpNext for any anime show and see how there headings and titles are labeled and provide screenshots and maybe there is a small possible chance we could match that for our NextUp.

Nuklear92 commented 9 months ago

Hey so UpNext is quite weird when it comes to naming and episode which honestly, i don't understand at all, you may wanna ask @Gujal00 about this sense i know nothing about NextUp unfortunately. Now about your trakt scrobbling situation, you may not be able to scrobble every anime cause reason why is cause anime has a different database then what trakt offers, the closest thing to trakt i would recommend is simkl cause simkl is basically like trakt but with an anime supported database. It also supports trakt integration so you can import your trakt and all.

If you don't mind, see how Seren does there UpNext for any anime show and see how there headings and titles are labeled and provide screenshots and maybe there is a small possible chance we could match that for our NextUp.

Absolutely, here it's;

Seren's Up-Next

image

image

As you can see, the name parsing is also the correct one.

Goldenfreddy0703 commented 9 months ago

Ok interesting, thank you very much, in the future lets make Seren NextUp like Otaku NextUp but only for name parsing and headers. Maybe @Gujal00 or @joezito129 can look into this but it may take some time.

Thank you

Goldenfreddy0703 commented 9 months ago

Actually nevermind, could not come up with a good title so gave up and labeled as bug. Will look in the Next Up tho and see what i can do. Thanks

Nuklear92 commented 9 months ago

Ok interesting, thank you very much, in the future lets make Seren NextUp like Otaku NextUp but only for name parsing and headers. Maybe @Gujal00 or @joezito129 can look into this but it may take some time.

Thank you

Awesome, no rush! Take all the time you guys need, I just wanted to report the issue. πŸ˜„πŸ‘

Gujal00 commented 9 months ago

I have mentioned this many times to stop comparing Seren with Otaku. Seren uses Trakt for next up so the names will always match with trakt. Otaku uses Anilist/Mal/Kitsu/Simkl for next up and the naming is different. We could tweak the labels a little to improve trakt scrobbling but there will always be a mismatch with seasons for all long anime which trakt breaks into seasons whileAnilist/Mal/Kitsu/Simkl treat them as a single season.

Goldenfreddy0703 commented 9 months ago

Yeah I just meant tweaking the labels, that's all. Sorry about that and thank you

Nuklear92 commented 9 months ago

That's what I looking forward to really, tweaking the labels. I understand that Otaku doesn't rely on Trakt. But, when you manually navigate to the title show and season. Episodes label the names exactly as in general all other streaming addons do, including Seren. It's only Otaku's "Next Up" that's labeling the names weirdly and I believe it's what's making the Trakt addon not kick in the scrobbing. As I mentioned in my original comment the Trakt addon does work if you browse manually into the show's title and season, because the label names are correct as shown in my screenshots.

So, hopefully tweaking the labels will work, of course if it's possible to make that change. πŸ‘

Goldenfreddy0703 commented 9 months ago

That's cause our next up only has the TV title label, not the episode label which is why your trakt is not scrobbleing unfortunately.

Nuklear92 commented 9 months ago

That's cause our next up only has the TV title label, not the episode label which is why your trakt is not scrobbleing unfortunately.

Oh, I see! So, do you think you guys could make that label name tweak without nothing breaking from the Next Up overall? πŸ€”

Goldenfreddy0703 commented 9 months ago

I'm not too sure, that's up to either @Gujal00 or @joezito129

Nuklear92 commented 9 months ago

I'm not too sure, that's up to either @Gujal00 or @joezito129

I see, well in case you guys think that will bring any issues or break other stuff just close the issue without notice. I can just continue doing the tracking manually in the Trakt app. I opened the issue thinking the solution was a bit simpler, hehe. πŸ˜…

Gujal00 commented 9 months ago

Yep, unfortunately when we pull up the current watchlist from anilist we only have the anime name, episodes watched, and when then next episode is being aired. So can't realistically get the episode title at that point. It is basically showing the same info as the https://anilist.co/home when you login