GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
101 stars 52 forks source link

errorLog: _notifyEvents #4193

Closed L03TJ3 closed 5 months ago

L03TJ3 commented 5 months ago

Description

About # (link your issue here)

4178

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 9:30am
2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **gooddollar-delta** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/gooddollar-delta/7w37zqzuQ4LMKV7FFMxshD2xTT8H)) | [Visit Preview](https://gooddollar-delta-git-4178-sentry-notifyevents-gooddollarteam.vercel.app) | | Jan 25, 2024 9:30am | | **goodid** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/goodid/GtJt3N12bmoox7s2Q3mLoB3Lyvoi)) | [Visit Preview](https://goodid-git-4178-sentry-notifyevents-gooddollarteam.vercel.app) | | Jan 25, 2024 9:30am |
sirpy commented 5 months ago

@L03TJ3 we know the txhash is null in these errors, so it only makes sense the log the whole event

L03TJ3 commented 5 months ago

@sirpy see my comment in the original issue. I disagree. we don't know yet 100% if its the input event, or the getReceiptWithLogs failing. If this log now shows null for event: we know its the input events if thie log shows with a txHash: we know it for sure its the getReceiptWithLogs

I just really don't see how a fetch transactions through the api's gives us a list of transactions or events without hash. Doesnt make sense

L03TJ3 commented 5 months ago

closing, fixed on master

sirpy commented 5 months ago

@L03TJ3 how was this fixed on master? where did you add the log for the event?

L03TJ3 commented 5 months ago

@sirpy I wanted to do that, but I appear to not have pushed that. added now, can be pushed as hotfix once the wallet is released