search

GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

[Bug, mobile, WalletConnect]: Swapping fails to calculate gas correctly #555

Open L03TJ3 opened 1 month ago

L03TJ3 commented 1 month ago

Bug Description It seems that sometimes on mobile when connected with GoodDollar wallet (wallet-connect) there are connection issues.

  1. confirmation in wallet shows immediately an 'Could not approve request'. (Seen on celo, screen 1)
  2. after switching to fuse and trying to swap, the confirmation never shows up.
  3. after switching to fuse it shows a modal 'this transaction will likely fail' (no screen available, does not happen all the time)
  4. after disconnecting wallet and restarting wallet, try and reconnect on gooddapp. It could be the confirmation from point 2 still shows up (there is no active connection anymore)

It's not sure if the issue is in the wallet or gooddapp, so this should also be tested against another dapp (like uniswap)

Steps to Reproduce

  1. Go to gooddapp (mobile)
  2. Click on wallet-connect
  3. connect wallet (android app)
  4. try swapping

Expected Behavior Swapping should work as expected

Additional Context (Could not approve request) image

decentralauren commented 1 month ago

Need priority

L03TJ3 commented 4 weeks ago

@decentralauren what does your last comment mean? that it is given priority or that it should be decided on still.

I see its still in 'new issues', but I thought it was supposed to be in this current sprint correct?

decentralauren commented 4 weeks ago

@L03TJ3 I believe the question was whether to prioritize immediately or wait for this sprint, so yes it should be in sprint.