search

GoodSign2017 / mochadoom

A pure Java Doom source port
GNU General Public License v3.0
0 stars 1 forks source link

Screen border isn't like vanilla Doom #6

Open AXDOOMER opened 7 years ago

AXDOOMER commented 7 years ago

The screen border in vanilla Doom looks like this:

In Mocha, it looks like this. Maybe scaling the little bezel properly will also fix the proportions of the borders which are not equal. The upper and bottom borders are thinner than the lateral borders. 2017-05-07-134451_1680x1050_scrot

GoodSign2017 commented 7 years ago

Yeah, you absolutely right.

GoodSign2017 commented 7 years ago

But the proportions is a different thing. Probably it is more related to 320x200 in 4:3 hackyness of vanilla.

AXDOOMER commented 7 years ago

By proportion I mean their wideness, but I'm sure this bug can be fixed by scaling the bezel correctly.

GoodSign2017 commented 7 years ago

I've tried to do that, but no, just scaling border does not make the window size properly vanilla. Unfortunately. So, not very easy to fix this issue. Would try to take some look into original DOOM source for formulas. I am sure something is misunderstood in Mocha Doom when calculating ingame render window dimensions.

If there are no formulas, only fixed values, the fine... Still the graphics system supports any kind of scaled coordinates conversion, just give it VideoScale object and some flags...

GoodSign2017 commented 7 years ago

The bezel should be scaled properly now. Windows size - not yet.

GoodSign2017 commented 7 years ago

Yeah. Found the formula in DOOM source and applied! Check it out in 0418299

I've made it set vanilla window size when tile scaling is on (by default) But I kept MAES's formula for when its off, because I think it looks better with unscaled tiles when using MAES's formula