GoogleChrome / lighthouse-ci

Automate running Lighthouse for every commit, viewing the changes, and preventing regressions
Apache License 2.0
6.45k stars 651 forks source link

improve filename sanitization for hash routes #1084

Open Awsum-Al opened 1 week ago

Awsum-Al commented 1 week ago

This enhancement modifies the filename sanitization process to handle hash-based routing more elegantly. By removing leading underscores from sanitized values, we create cleaner and more readable filenames for Single Page Applications using hash-based navigation.

Changes:

Example transformation: Before: _dashboard-2024_11_13.report.html After: dashboard-2024_11_13.report.html

google-cla[bot] commented 1 week ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.