Modernize JavaScript code

GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS

https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco

Apache License 2.0

135 stars 49 forks source link

Modernize JavaScript code #264

Open emaxx-google opened 3 years ago

emaxx-google commented 3 years ago

Currently, the JavaScript code in this repository follows pretty old guidelines (in some aspects, a few-years-old one). The code doesn't conform to the current Google JavaScript Style Guide (https://google.github.io/styleguide/jsguide.html) in several aspects, most notably:

Instead of modules, the goog.require+goog.provide combination is used.
Instead of const/let, var is used.
Instead of JavaScript classes, functions with the @constructor annotations are used.

emaxx-google commented 3 years ago

Besides just cleaning up the code, fixing this will also allow us to update to recent versions of Closure Compiler and Closure Library. Currently we're blocked, since the recent versions of Closure Compiler require the usage of JS modules.