Open mod3x opened 1 year ago
interesting strategy of consolidation as a post processing step. i had assumed a "resume state" strategy would be best, like finding an existing :root
context and using it instead of making a new one PLUS cataloging already inserted props for cross referencing before inserting. but this probably works just as good, and maybe has some advantages because it shows up at the end after the entirety of props have been placed. worth exploring further, thanks for sharing!
some additional test ideas:
:root
already has the prop that's being used, so the plugin should essentially do nothing.:root
s that it didnt append into": Seems clear that a "understand the state of the world for custom props in this project" is important for this functionality. Either doing that up front or as a post process. Thanks for hackin on this, let me know how else I can provide some assistance 🙂
Hi. This PR is an attempt to resolve issue #16. Currently, it merges :root rules in the OnceExit listener when all mutations are completed. However, I'm concerned that this solution may be too simplistic. Additionally, I've only added one test case, which I don't think is enough. Let's discuss this further and try to find a better solution. Thank you.