search

GoogleChromeLabs / simplehttp2server

A simple HTTP/2 server for development
Other
1.74k stars 99 forks source link

Content-Length header wrong/broken/missing/sad/depleted/ruined #17

Closed paullewis closed 7 years ago

paullewis commented 7 years ago

Not seeing it show up (comes through as null for response.headers.get('Content-Length').

Switching off gzip makes it all hunky dory.

surma commented 7 years ago

I completely removed gzip support for now

paullewis commented 7 years ago

Yah booooooo. I like gzip.

paullewis commented 7 years ago

supportbrotli

surma commented 7 years ago

The issue is mostly that I’d have to compress ahead-of-time in memory to figure out the compressed size to set Content-Length. Once I figure out a good way to do that, I might add it back in ¯_(ツ)_/¯

surma commented 7 years ago

It should work with streaming gzip and whitelist/blacklist to skip over media files.

surma commented 7 years ago

GZIP’s baaaaack! cc @jakearchibald