Shouldn't cross compiling "go get" "github.com/NYTimes/gziphandler"?

GoogleChromeLabs / simplehttp2server

A simple HTTP/2 server for development

Other

1.74k stars 99 forks source link

Shouldn't cross compiling "go get" "github.com/NYTimes/gziphandler"? #29

Closed diligiant closed 7 years ago

diligiant commented 7 years ago

simplehttp2server is embedded in a number of non-go projects and using one of them today on a "virgin" environnement, I noticed crosscompile.sh failed looking for gziphandler.

So I was wondering if you shouldn't "go get" or benefit from vendoring?

surma commented 7 years ago

I patched that yesterday. See #27

diligiant commented 7 years ago

Thank you ; I guess I have to lift up the requirements of 3.1.3 ;)

oren commented 7 years ago

I had the same issue - https://github.com/developit/preact-cli/issues/73#issuecomment-305995923