Closed mike-north closed 7 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
Yup, that makes a lot of sense. Thank you very much, @mike-north!
The That browser warning section of the readme states
However the Chromium FAQ on service worker debugging reads
I think the nuance here comes from the fact that, although the spec for HTTP/2 doesn't require secure connections, it has only been implemented in modern browsers for TLS connections. Thus, I think the issue at hand is:
HTTP://localhost
, they won't be happy withHTTPS://localhost
if a certificate error is encounteredWhy should we care? There's a common misconception that developers must trust a certificate when developing with service workers on http://localhost. The current README language is broad enough to reinforce this misconception.