search

GoogleChromeLabs / text-app

A text editor for ChromeOS and Chrome
https://chrome.google.com/webstore/detail/mmfbcljfglbokpmkimbfghdkjmjhdgbg
Other
554 stars 149 forks source link

Improve sidebar focus #587

Closed ZufengW closed 1 year ago

ZufengW commented 1 year ago

Two main changes for accessibility reasons:

  1. Prevent keyboard navigation into the sidebar when it's closed
    • Previously, it was possible to tab to buttons inside the sidebar even when it was closed
  2. Make focus stay on the toggle sidebar button after it's clicked
    • Previously, focus would move to the editor
google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ZufengW commented 1 year ago

I committed with the wrong email 🤦

It's easier to make new commits, so I'll abandon this PR.

Replacement: https://github.com/GoogleChromeLabs/text-app/pull/588