GoogleChromeLabs / web-gphoto2

Running gPhoto2 to control DSLR cameras over USB on the Web
https://web-gphoto2.rreverser.com/
GNU Lesser General Public License v2.1
101 stars 16 forks source link

Fix: Vite Build Error (vite:worker-import-meta-url) #11

Closed irvandikky closed 10 months ago

irvandikky commented 1 year ago

There is an issue if using this module with vite build in libapi.mjs add { type: "module" } should fix build error

image

Related Issue

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

icheered commented 1 year ago

IIRC libapi.mjs (the only file changed in this PR) is automatically generated. Any changes made to the file are reverted upon rebuilding the project. If you want to find a way to solve this issue you should fix it in such a way that after building the project it is fixed :)

icheered commented 10 months ago

This PR can be closed, I fixed the issue in #12

RReverser commented 10 months ago

Closing to merge discussion into #12.