GoogleCloudPlatform / cloud-logging-data-source-plugin

https://grafana.com/grafana/plugins/googlecloud-logging-datasource/
Apache License 2.0
17 stars 13 forks source link

Support for Ad Hoc filters #80

Open johnewhitley opened 3 months ago

johnewhitley commented 3 months ago

Is your feature request related to a problem? Please describe. Currently, when using the cloud logging data source plugin in grafana, we can not use Ad Hoc grafana filters to drive changes in the visualization.

Grafana Ad Hoc vars

Describe the solution you'd like Ideally, I'd like to be able to click a log line in a log dashboard, click on the "+" or "-" button to create an Ad Hoc filter to show me matches (or non matches) of logs. Ex below:

image

This is supported by several other datasources. Loki doc shows support for Ad Hoc filtering.

This would allow folks to drive queries natively in the dashboards without having to use explore or open/edit a dashboard to update/edit the query.

xiangshen-dk commented 1 month ago

When you click the + sign, the plugin will update with the field. You do need to click the Run query button to run the new query though.

johnewhitley commented 1 month ago

Where is the run query button?

On Wed, Sep 4, 2024 at 9:42 PM xiangshen-dk @.***> wrote:

When you click the + sign, the plugin will update with the field. You do need to click the Run query button to run the new query though.

— Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/cloud-logging-data-source-plugin/issues/80#issuecomment-2330436530, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3GGPXIOINVLPW2O6WPBBLZU6ZKDAVCNFSM6AAAAABLFCK3D2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQGQZTMNJTGA . You are receiving this because you authored the thread.Message ID: <GoogleCloudPlatform/cloud-logging-data-source-plugin/issues/80/2330436530 @github.com>

xiangshen-dk commented 1 month ago

image

johnewhitley commented 1 month ago

Ah yeah, that does work, but this does not work when you use the cloud logging data source as a dashboard whereas Loki does.