GoogleCloudPlatform / getting-started-python

Code samples for using Python on Google Cloud Platform
https://cloud.google.com/python
Apache License 2.0
788 stars 591 forks source link

Replace python-jose with google alternative #566

Open Jipje opened 7 months ago

Jipje commented 7 months ago

Closes #565

For more context to why python-jose should be replaced, please reference #565

This solution is a modified version of another repository of GoogleCloudPlatform: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/iap/validate_jwt.py. Although the code was modified as to minimize the amount of changes necessary in this repository.

The certs() method and CERTS global have been replaced by a certs_url parameter in the verify_token method. This did not change behaviour in the tests.

snippet-bot[bot] commented 7 months ago

Here is the summary of changes.

You are about to delete 1 region tag. - [authenticating-users/main.py:25](https://github.com/GoogleCloudPlatform/getting-started-python/blob/d9da8db203f7729f5da28b57be66b69084955bde/authenticating-users/main.py#L25), tag `getting_started_auth_certs`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

iennae commented 6 months ago

@Jipje thanks for raising this and investigating a solution

/gcbrun

Jipje commented 6 months ago

Cheers @iennae, happy to help out. I am unable to view the details of the kokoro build so am unsure as to why it fails.

Is it anything to do with the adjusted # [START getting_started_auth_certs] comments?

Jipje commented 5 months ago

Bumping this @iennae