search

GoogleCloudPlatform / inspec-gcp-pci-profile

GCP PCI-DSS 3.2.1 InSpec Profile
Apache License 2.0
18 stars 15 forks source link

Skip firewall checks if there is no VPC #27

Closed KonradSchieban closed 4 years ago

KonradSchieban commented 4 years ago

fixes https://github.com/GoogleCloudPlatform/inspec-gcp-pci-profile/issues/25

KonradSchieban commented 4 years ago

/gcbrun

aaronlippold commented 4 years ago

Are we sure these shouldn't be set to non applicable aka impact zero when they skip or is it truly an absent subcomponent

KonradSchieban commented 4 years ago

/gcbrun

KonradSchieban commented 4 years ago

Are we sure these shouldn't be set to non applicable aka impact zero when they skip or is it truly an absent subcomponent

@aaronlippold would you suggest to rather skip each check with zero impact than skip all at once at the top?

KonradSchieban commented 4 years ago

/gcbrun