GoogleCloudPlatform / inspec-gcp-pci-profile

GCP PCI-DSS 3.2.1 InSpec Profile
Apache License 2.0
18 stars 15 forks source link

remove default values from inputs in the `inspec.yml` if they can't have a default #37

Open aaronlippold opened 4 years ago

aaronlippold commented 4 years ago

It seems that many of these shared inputs are actually user-provided input via an inputs.yml file at run time. If this is the case, then just having an input name and required:true in the inspec.yml is what you want.

Then when the user does not provide the needed data at run-time the profile and inspec will ask the user to provide the data and direct them to the inputs docs on the site.

KonradSchieban commented 3 years ago

We have 34 parameters at this point. I am not sure if we want to make all of them required (despite the tests fail if parameters aren't provided) because it would make it difficult to get started with the profile. @binamov any thoughts on this?