GoogleCloudPlatform / inspec-gcp-pci-profile

GCP PCI-DSS 3.2.1 InSpec Profile
Apache License 2.0
18 stars 15 forks source link

better matcher #8

Closed binamov closed 4 years ago

binamov commented 4 years ago

The usecase we're solving for:

the cmp matcher was checking for all regions to be present the be_in matcher helps check for one, or a few, not necessarily all

@bgeesaman thoughts?

aaronlippold commented 4 years ago

the be_in compares two sets have the same elements regardless of order

binamov commented 4 years ago

@aaronlippold are you saying we can clean up some of those .sorts?

aaronlippold commented 4 years ago

Yes I am :)

Aaron Lippold

lippold@gmail.com

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

On Wed, Mar 25, 2020 at 5:23 PM Bakh Inamov notifications@github.com wrote:

@aaronlippold https://github.com/aaronlippold are you saying we can clean up some of those .sorts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/inspec-gcp-pci-profile/pull/8#issuecomment-604095004, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK42GMFV4HXBCUFFTQGHTRJJY3VANCNFSM4LTXXNCA .

aaronlippold commented 4 years ago

Hi,

Can I get a script that would setup my GCP env to allow all the controls to run without error. I am still getting 38 profile errors on the controls in the 'mitre-saf' gcp env.

I would like to have a clean env to run in to help push up some suggestions.

Thanks,

Aaron Lippold

lippold@gmail.com

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

On Thu, Mar 26, 2020 at 5:35 PM Bakh Inamov notifications@github.com wrote:

Merged #8 https://github.com/GoogleCloudPlatform/inspec-gcp-pci-profile/pull/8 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/inspec-gcp-pci-profile/pull/8#event-3170172250, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK42F47WFS6IGVLDKFSYTRJPDC5ANCNFSM4LTXXNCA .