Fix examples (Makefiles, logging, comments, readability).

GoogleCloudPlatform / iot-device-sdk-embedded-c

Cloud IoT Device SDK for Connectivity to IoT Core.

Other

247 stars 83 forks source link

Fix examples (Makefiles, logging, comments, readability). #46

Open verkri opened 5 years ago

verkri commented 5 years ago

Reason for this PR: I was playing with the examples and found many issues that potential clients might hit as well. These are:

Inconsistent logging in binaries,
unbuildable iot_core_mqtt_client,
Potential Build errors when building multiple examples (TLS platform incompatibility),
Inconsistent style of comments in code,
Brittle Makefiles.

I went on and moved all IoT Core parameters into a struct for better encapsulation, which resulted also in a refactor in the common libraries.

sheindel commented 4 years ago

@verkri I love some of the work you've done here, and I think it really improves the project. Would you be open to resolving the file conflicts so we can resurrect your efforts and get this merged in?

galz10 commented 4 years ago

Hi @verkri thank you for pointing out these issues, do you still want to merge this PR if so could you submit a no-op change so Travis CI could run its tests, if not i'll close out the PR.