GoogleCloudPlatform / iot-device-sdk-embedded-c

Cloud IoT Device SDK for Connectivity to IoT Core.
Other
247 stars 83 forks source link

zephyr_bsp/iotc_bsp_io_fs_zephyr.c: Use standard <string.h> header. #70

Closed pfalcon closed 5 years ago

pfalcon commented 5 years ago

There's no in ANSI C or POSIX.

Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org

pfalcon commented 5 years ago

Breaks the build for real Zephyr targets.

cc: @d3zd3z, @galak

d3zd3z commented 5 years ago

Any idea where the memory.h header even comes from? It is present in glibc, with an "SVID" comment, but I can't find it anywhere in SVID. I'm guessing it was put there for compatibility with something. But, this patch is correct, code should be using string.h and not memory.h.

pfalcon commented 5 years ago

Any idea where the memory.h header even comes from?

I believe it was there in Turbo C 1.0 on DOS ;-). So, some legacy header added for compatibility here and there (but not everywhere).