Closed donmccasland closed 5 years ago
That's an existing yaml for doing cleanup, usually called via build.sh
The new script just calls cleanup.yaml so we don't have to do a lot of extra console work
On Tue, Apr 30, 2019, 7:40 PM Sharif Elgamal notifications@github.com wrote:
@sharifelgamal commented on this pull request. In scripts/cleanup-manual.sh https://github.com/GoogleCloudPlatform/jetty-runtime/pull/259#discussion_r279996213 : + +IMAGE="${DOCKER_NAMESPACE}/${RUNTIME_NAME}:${TAG}" +echo "IMAGE: $IMAGE" + +STAGING_IMAGE="gcr.io/${GCP_TEST_PROJECT}/${RUNTIME_NAME}_staging:${TAG} http://gcr.io/$%7BGCP_TEST_PROJECT%7D/$%7BRUNTIME_NAME%7D_staging:$%7BTAG%7D" +AE_SERVICE_BASE="$(echo $BUILDTIMESTAMP | sed 's///g')" +TEST_AE_SERVICE_1="${AE_SERVICE_BASE}-v1" +TEST_AE_SERVICE_2="${AE_SERVICE_BASE}-v2" +GKE_TEST_APPLICATION="jetty-integration-test-app-$(date -u +%Y-%m-%d-%H-%M)" +CLUSTER_NAME="jetty-runtime-integration-cluster" + +set +e +set -x +# once build has completed, kick off async cleanup build +gcloud builds submit \ --config=${buildConfigDir}/cleanup.yaml \ What is cleanup.yaml? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/jetty-runtime/pull/259#pullrequestreview-232480296, or mute the thread https://github.com/notifications/unsubscribe-auth/AAF76US4FBA34E5R2NQ2XP3PTD7JNANCNFSM4HJRN2GA .
In scripts/cleanup-manual.sh https://github.com/GoogleCloudPlatform/jetty-runtime/pull/259#discussion_r279996213 :
+ +IMAGE="${DOCKER_NAMESPACE}/${RUNTIME_NAME}:${TAG}" +echo "IMAGE: $IMAGE" + +STAGING_IMAGE="gcr.io/${GCP_TEST_PROJECT}/${RUNTIME_NAME}_staging:${TAG} http://gcr.io/$%7BGCP_TEST_PROJECT%7D/$%7BRUNTIME_NAME%7D_staging:$%7BTAG%7D" +AE_SERVICE_BASE="$(echo $BUILDTIMESTAMP | sed 's///g')" +TEST_AE_SERVICE_1="${AE_SERVICE_BASE}-v1" +TEST_AE_SERVICE_2="${AE_SERVICE_BASE}-v2" +GKE_TEST_APPLICATION="jetty-integration-test-app-$(date -u +%Y-%m-%d-%H-%M)" +CLUSTER_NAME="jetty-runtime-integration-cluster" + +set +e +set -x +# once build has completed, kick off async cleanup build +gcloud builds submit \ --config=${buildConfigDir}/cleanup.yaml \
+ +IMAGE="${DOCKER_NAMESPACE}/${RUNTIME_NAME}:${TAG}" +echo "IMAGE: $IMAGE" + +STAGING_IMAGE="gcr.io/${GCP_TEST_PROJECT}/${RUNTIME_NAME}_staging:${TAG} http://gcr.io/$%7BGCP_TEST_PROJECT%7D/$%7BRUNTIME_NAME%7D_staging:$%7BTAG%7D" +AE_SERVICE_BASE="$(echo $BUILDTIMESTAMP | sed 's///g')" +TEST_AE_SERVICE_1="${AE_SERVICE_BASE}-v1" +TEST_AE_SERVICE_2="${AE_SERVICE_BASE}-v2" +GKE_TEST_APPLICATION="jetty-integration-test-app-$(date -u +%Y-%m-%d-%H-%M)" +CLUSTER_NAME="jetty-runtime-integration-cluster" + +set +e +set -x +# once build has completed, kick off async cleanup build +gcloud builds submit \
What is cleanup.yaml?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/jetty-runtime/pull/259#pullrequestreview-232480296, or mute the thread https://github.com/notifications/unsubscribe-auth/AAF76US4FBA34E5R2NQ2XP3PTD7JNANCNFSM4HJRN2GA .
That's an existing yaml for doing cleanup, usually called via build.sh
The new script just calls cleanup.yaml so we don't have to do a lot of extra console work
On Tue, Apr 30, 2019, 7:40 PM Sharif Elgamal notifications@github.com wrote: