Closed jsoref closed 1 week ago
The first error appears to be:
2024-11-20T20:36:32.1050618Z utils.go:110: FAIL: unexpected diff in /home/runner/work/k8s-config-connector/k8s-config-connector/pkg/test/resourcefixture/testdata/basic/bigquery/v1beta1/bigquerydataset/fullybigquerydataset/_http.log: (
"""
... // 565 identical lines
{
"role": "OWNER",
- "userByEmail": "user@google.com"
+ "specialGroup": "projectOwners"
},
{
"role": "OWNER",
- "specialGroup": "projectOwners"
+ "userByEmail": "user@google.com"
}
],
... // 373 identical lines
"""
)
Which doesn't seem like something I'm doing...
The first error appears to be:
2024-11-20T20:36:32.1050618Z utils.go:110: FAIL: unexpected diff in /home/runner/work/k8s-config-connector/k8s-config-connector/pkg/test/resourcefixture/testdata/basic/bigquery/v1beta1/bigquerydataset/fullybigquerydataset/_http.log: (
""" ... // 565 identical lines { "role": "OWNER", - "userByEmail": "user@google.com" + "specialGroup": "projectOwners" }, { "role": "OWNER", - "specialGroup": "projectOwners" + "userByEmail": "user@google.com" } ], ... // 373 identical lines """ )
Which doesn't seem like something I'm doing...
yeah. The presubmit was broken. Could you rebase from master head? It should pass now
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: yuwenma
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Change description
Subset of #3062
Tests you have done
make ready-pr
to ensure this PR is ready for review.