GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
902 stars 235 forks source link

[CHORE] Spelling 10/n #3218

Closed jsoref closed 1 week ago

jsoref commented 1 week ago

Change description

Subset of #3062

Tests you have done

jsoref commented 1 week ago

The first error appears to be:

2024-11-20T20:36:32.1050618Z     utils.go:110: FAIL: unexpected diff in /home/runner/work/k8s-config-connector/k8s-config-connector/pkg/test/resourcefixture/testdata/basic/bigquery/v1beta1/bigquerydataset/fullybigquerydataset/_http.log:   (
    """
    ... // 565 identical lines
        {
          "role": "OWNER",
-         "userByEmail": "user@google.com"
+         "specialGroup": "projectOwners"
        },
        {
          "role": "OWNER",
-         "specialGroup": "projectOwners"
+         "userByEmail": "user@google.com"
        }
      ],
    ... // 373 identical lines
    """
  )

Which doesn't seem like something I'm doing...

yuwenma commented 1 week ago

The first error appears to be:

2024-11-20T20:36:32.1050618Z     utils.go:110: FAIL: unexpected diff in /home/runner/work/k8s-config-connector/k8s-config-connector/pkg/test/resourcefixture/testdata/basic/bigquery/v1beta1/bigquerydataset/fullybigquerydataset/_http.log:   (
    """
      ... // 565 identical lines
          {
            "role": "OWNER",
-           "userByEmail": "user@google.com"
+           "specialGroup": "projectOwners"
          },
          {
            "role": "OWNER",
-           "specialGroup": "projectOwners"
+           "userByEmail": "user@google.com"
          }
        ],
      ... // 373 identical lines
      """
  )

Which doesn't seem like something I'm doing...

yeah. The presubmit was broken. Could you rebase from master head? It should pass now

yuwenma commented 1 week ago

/lgtm

yuwenma commented 1 week ago

/approve

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [yuwenma] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment