Open jsoref opened 1 week ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
I tried hack/compare-mock fixtures/regionalcomputetargettcpproxy-direct
and got:
diff --git a/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log b/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log
index 1c70b18a1..053014c98 100644
--- a/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log
+++ b/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log
@@ -225,7 +225,7 @@ X-Xss-Protection: 0
GET https://compute.googleapis.com/compute/v1/projects/${projectId}/regions/europe-west4/targetTcpProxies/${targetTcpProxyID}
Content-Type: application/json
User-Agent: kcc/controller-manager
-x-goog-request-params: project=${projectId}®ion=europe-west4&target_tcp_proxy=computetargettcpproxy-${uniqueId}
+x-goog-request-params: project=${projectId}®ion=europe-west4&target_tcp_proxy=${targetTcpProxyID}
404 Not Found
Cache-Control: private
@@ -335,7 +335,7 @@ X-Xss-Protection: 0
GET https://compute.googleapis.com/compute/v1/projects/${projectId}/regions/europe-west4/targetTcpProxies/${targetTcpProxyID}
Content-Type: application/json
User-Agent: kcc/controller-manager
-x-goog-request-params: project=${projectId}®ion=europe-west4&target_tcp_proxy=computetargettcpproxy-${uniqueId}
+x-goog-request-params: project=${projectId}®ion=europe-west4&target_tcp_proxy=${targetTcpProxyID}
200 OK
Cache-Control: private
@@ -366,7 +366,7 @@ X-Xss-Protection: 0
DELETE https://compute.googleapis.com/compute/v1/projects/${projectId}/regions/europe-west4/targetTcpProxies/${targetTcpProxyID}
Content-Type: application/json
User-Agent: kcc/controller-manager
-x-goog-request-params: project=${projectId}®ion=europe-west4&target_tcp_proxy=computetargettcpproxy-${uniqueId}
+x-goog-request-params: project=${projectId}®ion=europe-west4&target_tcp_proxy=${targetTcpProxyID}
200 OK
Cache-Control: private
Which seems kinda odd.
Change description
Subset of #3062
Tests you have done
make ready-pr
to ensure this PR is ready for review.