GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
902 stars 235 forks source link

[CHORE] Spelling 11/n #3219

Open jsoref opened 1 week ago

jsoref commented 1 week ago

Change description

Subset of #3062

Tests you have done

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsoref commented 1 week ago

I tried hack/compare-mock fixtures/regionalcomputetargettcpproxy-direct and got:

diff --git a/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log b/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log
index 1c70b18a1..053014c98 100644
--- a/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log
+++ b/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log
@@ -225,7 +225,7 @@ X-Xss-Protection: 0
 GET https://compute.googleapis.com/compute/v1/projects/${projectId}/regions/europe-west4/targetTcpProxies/${targetTcpProxyID}
 Content-Type: application/json
 User-Agent: kcc/controller-manager
-x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=computetargettcpproxy-${uniqueId}
+x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=${targetTcpProxyID}

 404 Not Found
 Cache-Control: private
@@ -335,7 +335,7 @@ X-Xss-Protection: 0
 GET https://compute.googleapis.com/compute/v1/projects/${projectId}/regions/europe-west4/targetTcpProxies/${targetTcpProxyID}
 Content-Type: application/json
 User-Agent: kcc/controller-manager
-x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=computetargettcpproxy-${uniqueId}
+x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=${targetTcpProxyID}

 200 OK
 Cache-Control: private
@@ -366,7 +366,7 @@ X-Xss-Protection: 0
 DELETE https://compute.googleapis.com/compute/v1/projects/${projectId}/regions/europe-west4/targetTcpProxies/${targetTcpProxyID}
 Content-Type: application/json
 User-Agent: kcc/controller-manager
-x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=computetargettcpproxy-${uniqueId}
+x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=${targetTcpProxyID}

 200 OK
 Cache-Control: private

Which seems kinda odd.