feat: Turn on ComputeTCPProxy direct controller

GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources

https://cloud.google.com/config-connector/docs/overview

Apache License 2.0

902 stars 235 forks source link

feat: Turn on ComputeTCPProxy direct controller #3227

Open gemmahou opened 1 week ago

gemmahou commented 1 week ago

Change description

Turn on ComputeTCPProxy direct controller

Tests you have done

samples test passed:

go test -v -tags=integration ./config/tests/samples/create -test.run TestAll -run-tests regional-target-tcp-proxy
...
ok      github.com/GoogleCloudPlatform/k8s-config-connector/config/tests/samples/create 75.450s

[x] Run make ready-pr to ensure this PR is ready for review.
[x] Perform necessary E2E testing for changed resources.

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from yuwenma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

gemmahou commented 1 week ago

/hold

Found two issues to be addressed before we can turn on direct controller: #3236 and #3237