Closed maqiuyujoyce closed 3 days ago
Some nits but not blocking. Will approve & hold so you can see them before they disappear!
/approve /lgtm /hold
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/hold cancel
Change description
When there are a lot of dependent non-direct resources in the test case, the comparison between real GCP http log and mock GCP http log can be messy. With the new env var
ONLY_COMPARE_URL_PREFIX
, we can focus on the comparison of the target resource/API in the http log events.Tests you have done
make ready-pr
to ensure this PR is ready for review.