GoogleCloudPlatform / k8s-config-connector

GCP Config Connector, a Kubernetes add-on for managing GCP resources
https://cloud.google.com/config-connector/docs/overview
Apache License 2.0
902 stars 235 forks source link

Support env var to only compare http log events with given URL prefix #3245

Closed maqiuyujoyce closed 3 days ago

maqiuyujoyce commented 1 week ago

Change description

When there are a lot of dependent non-direct resources in the test case, the comparison between real GCP http log and mock GCP http log can be messy. With the new env var ONLY_COMPARE_URL_PREFIX, we can focus on the comparison of the target resource/API in the http log events.

Tests you have done

justinsb commented 1 week ago

Some nits but not blocking. Will approve & hold so you can see them before they disappear!

/approve /lgtm /hold

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 4 days ago

/lgtm

maqiuyujoyce commented 3 days ago

/hold cancel