GoogleCloudPlatform / k8s-stackdriver

Apache License 2.0
389 stars 211 forks source link

wrong version of file in tag #653

Open dlesco opened 4 months ago

dlesco commented 4 months ago

For tag cm-sd-adapter-v0.14.2

the wrong version of deploy/production/adapter_new_resource_model.yaml is included in the tag.

CatherineF-dev commented 3 months ago

Thanks for reporting this issue!

In checking.

CatherineF-dev commented 3 months ago

Hi @dlesco, could you provide more details around this issue? Thx!

CatherineF-dev commented 3 months ago

Hello

CatherineF-dev commented 2 months ago

Found it. The version inside deploy/production/adapter_new_resource_model.yaml under cm-sd-adapter-v0.14.2 is not v0.14.2.

It's because the current build flow is 1. create a tag in github 2. sync-ed this tag into internal CI/CD pipeline 3. new image is built.

Will find a way to fix it.