GoogleCloudPlatform / ml-design-patterns

Source code accompanying O'Reilly book: Machine Learning Design Patterns
Apache License 2.0
1.89k stars 532 forks source link

Chapter 2 : Feature Cross - Error in explaining text #23

Open jeromemassot opened 3 years ago

jeromemassot commented 3 years ago

Dear authors,

The text

'''Creating a Feature Cross with BQML Next, we'll create a feature cross of the features is_male and mother_race. To create a feature cross we apply ML.FEATURE_CROSS to a STRUCT of the features is_male and mother_race cast as a string. The STRUCT clause creates an ordered pair of the two features. The TRANSFORM clause is used for engineering features of our model. This allows us to specify all preprocessing during model creation and apply those preprocessing steps during prediction and evaluation. The rest of the features within the TRANSFORM clause remain unchanged.'''

has to be changed as the two features crossed are 'is_male' and 'plurality' not 'mother_race'

Thanks

Best regards

Jerome