Add resource attributes as metric labels - Githubissues

GoogleCloudPlatform / opentelemetry-operations-java

Apache License 2.0

71 stars 41 forks source link

Add resource attributes as metric labels #314

Closed psx95 closed 5 months ago

psx95 commented 5 months ago

Feature Addition

Adds user configurable option to attach service.name, service.namespace and service.id resource attributes to metric labels.
This can be disabled by passing the provided NO_RESOURCE_ATTRIBUTES as the resource filter to the MetricConfiguration object.
The default metric configuration has been changed to use the DEFAULT_RESOURCE_ATTRIBUTES_FILTER.

Note: This is similar to how the Google Cloud Monitoring go exporter works.

Testing

When running the auto-instrumentation-example, service_name appears under metric labels on GCP console with the expected value.
When running the metric export example, service_name appears with unknown_resource since the example does not include resource detection.

Deprecation

Deprecates the current publicly available AggregateByLabelMetricTimeSeriesBuilder constructor in favor of one that also accepts a resource attribute filter in form of a predicate. The existing constructor uses the NO_RESOURCE_ATTRIBUTES to keep it in-line with the existing functionality.

fixes #313