search

GoogleCloudPlatform / opentelemetry-operator-sample

Toolbox of recipes, samples, and guides for using the OpenTelemetry Operator on Google Cloud
Apache License 2.0
32 stars 16 forks source link

Needed to run a credentials helper for docker to make `make push` work #44

Open draffensperger opened 1 year ago

draffensperger commented 1 year ago

Thanks for making this great samples repo!

One small thing that seemed like it may have been a missing step. When I ran make setup it didn't actually seem to create the artifact repository for me - I created it manually.

I also needed to run gcloud auth configure-docker us-central1-docker.pkg.dev to authorize my local docker to talk to GCP artifact repository for make push command to work for me for the go app.

aabmass commented 1 year ago

When I ran make setup it didn't actually seem to create the artifact repository for me - I created it manually.

Do you remember what error you saw? It should be creating the artifact registry https://github.com/GoogleCloudPlatform/opentelemetry-operator-sample/blob/57b07411b81b73ceb0cf99834cef1773d44c3276/Makefile#L21

I also needed to run gcloud auth configure-docker us-central1-docker.pkg.dev to authorize my local docker to talk to GCP artifact repository for make push command to work for me for the go app.

👍 agreed, we should add it

draffensperger commented 1 year ago

I don't remember the exact error unfortunately, but if I hit it again I'll update here.